-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jackson version #1739
Upgrade jackson version #1739
Conversation
Not sure why checks aren't running. Looking into it |
Might be this https://www.githubstatus.com/ |
wait, at least need to add this line in several places per #1681
|
Job is queued: https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/10000088771 |
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
there will be integration test failures which I observed during 2.57.0rc1 validation, need to fix some code path, see #1739 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
============================================
- Coverage 42.32% 42.31% -0.01%
+ Complexity 3182 3180 -2
============================================
Files 794 794
Lines 46244 46244
Branches 4951 4951
============================================
- Hits 19572 19568 -4
- Misses 25074 25077 +3
- Partials 1598 1599 +1
|
@Abacn I already included these changes when I upgraded beam in #1695. IT's passed other than a couple Kafka IT's which have already been failing - I'm looking into those, but error is unrelated to the jackson upgrade. |
Apache Beam depends on Jackson 2.15.4 as of apache/beam#31473 which is breaking at least the JMS To PubSub template when deserializing pipeline options due to
which was a field added in 2.15.4